New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig 2.x fixes #169

Merged
merged 3 commits into from Sep 15, 2017

Conversation

Projects
None yet
4 participants
@benr77
Contributor

benr77 commented Jun 16, 2017

Small fixes to enable use under Twig 2.x. Fixes #164

benr77 added some commits Jun 16, 2017

Fixes for Twig 2.x compatibility
Added `{% if block('box_before') is defined %}` conditions around the non-essential block statements
Fixes for Twig 2.x compatibility
Added `{% if block('box_before') is defined %}` conditions around the non-essential block statements
Fixes for Twig 2.x compatibility
Import _self in to block context
@hounded

This comment has been minimized.

Show comment
Hide comment
@hounded

hounded Jul 19, 2017

Contributor

why are merges so slow on this ?
#152

Contributor

hounded commented Jul 19, 2017

why are merges so slow on this ?
#152

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran Sep 15, 2017

Collaborator

@avanzu could you quick review this PR if needs changes or could be merged quickly? It is important for new symfony users have updated this twig changes

Collaborator

shakaran commented Sep 15, 2017

@avanzu could you quick review this PR if needs changes or could be merged quickly? It is important for new symfony users have updated this twig changes

@chteuchteu

This comment has been minimized.

Show comment
Hide comment
@chteuchteu

chteuchteu Sep 15, 2017

Collaborator

Thank you for your contribution, sorry about the delay!

Collaborator

chteuchteu commented Sep 15, 2017

Thank you for your contribution, sorry about the delay!

@chteuchteu chteuchteu merged commit 603930c into avanzu:feature/2.0 Sep 15, 2017

@benr77 benr77 deleted the benr77:Twig-2.x-Fixes branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment