Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bootbox version #249

Merged
merged 1 commit into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@kainskadmin
Copy link

commented Feb 28, 2019

Fix bootbox version.

Bootbox was created new version 5.0.0 and now appear error Unable to find file "@AvanzuAdminThemeBundle/Resources/public/vendor/bootbox/bootbox.js"
when execute assetic:dump command. Bootbox 5.0.0 have a different structure, and not compatible with 4.x

Vladimir Butov

@kainskadmin kainskadmin changed the title fix bootfox version fix bootbox version Feb 28, 2019

@shakaran shakaran self-assigned this Feb 28, 2019

@shakaran shakaran added this to the Old 1.3.x versions milestone Feb 28, 2019

@shakaran shakaran merged commit 0c4e46f into avanzu:1.3.x Feb 28, 2019

1 check passed

Better Code Hub ✅ Better Code Hub approves this code
Details
@shakaran

This comment has been minimized.

Copy link
Collaborator

commented Feb 28, 2019

@kainskadmin Thanks for your contribution!

@bastos71

This comment has been minimized.

Copy link

commented Mar 1, 2019

@shakaran version 1.3.12 seems not available :/
https://packagist.org/packages/avanzu/admin-theme-bundle

I had to add this to my composer.json to be able to update to the latest version :

{
    ...
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/avanzu/AdminThemeBundle"
        }    
    ]
    ...
}
@shakaran

This comment has been minimized.

Copy link
Collaborator

commented Mar 1, 2019

@shakaran version 1.3.12 seems not available :/
https://packagist.org/packages/avanzu/admin-theme-bundle

I had to add this to my composer.json to be able to update to the latest version :

{
    ...
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/avanzu/AdminThemeBundle"
        }    
    ]
    ...
}

You dont needed, you should could update with something like:

composer require avanzu/admin-theme-bundle dev-master#1.3.12

@bastos71

This comment has been minimized.

Copy link

commented Mar 1, 2019

@shakaran Sorry but it seems it's not working, I had version 1.3.11 installed, and a composer update throws me "There is nothing to install/update"

Please, take a look at this link : https://packagist.org/packages/avanzu/admin-theme-bundle
Version 1.3.12 is not referenced by Packagist

@shakaran

This comment has been minimized.

Copy link
Collaborator

commented Mar 4, 2019

@bastos71 Since I am having some problems for update the packagist.org package (I already requested to be maintainer to avanzu main owner, but it could take time to it), I am maintaining the same commits and duplicating the work in a personal repo and packagist account:

composer require shakaran/admin-theme-bundle:1.3.12

https://packagist.org/packages/shakaran/admin-theme-bundle

So you can fetch there the 1.3.12 release tag for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.