This repository has been archived by the owner on Jul 6, 2018. It is now read-only.
run nopaste asynchronously #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps Emacs interactive while the paste is in progress. Output is shown through a filter handler.
This is useful for debugging purposes: by setting this variable to a string, users can keep the output of the nopaste command in a buffer to inspect why things fail when they do.
By specifying `:stderr` in the `make-process` call, we ensure that standard error output is not sent to the filter directly, and instead stored in the buffer. We still notify the user when we fail so it is useless to process errors as if they were URLs.
This is the proper way of handling errors at the end of a process. Doing so in the filter is error-prone is it might run before the process finishes
use -- seperator for private functions and variables, and name filter function correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps Emacs interactive while the paste is in progress. URL information is shown through a filter handler instead of synchronously, which means Emacs won't hang when sending content to the paste server. This matters because some pastebin can get busy or slow, especially on slower connexions, which currently makes Emacs completely unresponsive when pasting.
By default, the standard output of the command is discard but the "chomped" URL is shown to the user and copied to the kill ring, as before. Standard error is kept in a
*nopaste-errors*buffer for perusal on errors, and asentinelfunction handles such errors and defer the user to that buffer in case of problems. That was tested by disabling the network on my workstation and seems to behave well enough.The last commit also includes some style changes to the code to comply with common conventions.