Support OTP24 #11
Merged
Support OTP24 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping ruslter version to 0.22.2 instead of 0.23.0, since corresponding serde_rustler crate (actually, a fork of it) depends on ~> 0.22.0. Using serde_rustler' fork, due to: sunny-g/serde_rustler#14 sunny-g/serde_rustler#15 (not merged)
I don't know Rust, so going with the smallest & most naive approach possible:
error[E0004]: non-exhaustive patterns: `Term(_)` not covered
--> src/lib.rs:21:74
|
21 | let input: Result<&str, &str> = args[0].decode().map_err(|err| match err {
| ^^^ pattern `Term(_)` not covered
|
::: /Users/eugene/.cargo/registry/src/github.com-1ecc6299db9ec823/rustler-0.22.2/src/error.rs:19:5
|
19 | Term(Box<dyn Encoder>),
| ---- not covered
|
= help: ensure that all possible cases are being handled, possibly by adding wildcards or more match arms
= note: the matched value is of type `rustler::Error`
|
Oh awesome @gmile, you found a serde_rustler that's been updated for 0.22 |
|
Merged thank @gmile ❤️ 💜 💛 💙 |
|
@praveenperera awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update multiple packages to support OTP24. Closes #10.
ℹ️ rustler itself seems to have addressed the issue with OTP24 for some time now, see this thread: rusterlium/rustler#359