Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort filters 157855828 #140

Merged
merged 3 commits into from May 29, 2018
Merged

Sort filters 157855828 #140

merged 3 commits into from May 29, 2018

Conversation

gopalshimpi
Copy link
Member

@gopalshimpi gopalshimpi commented May 24, 2018

Added Sort filters and Pretty_name
1. Added newest,alphabetical sorts.
2. Added Pretty name for selected category.
[Deliver 157855828]

1. Added newest,alfabetical sorts.
2. Added Pretty name for selected category.
@gopalshimpi gopalshimpi changed the base branch from master to develop May 24, 2018 19:45
@gopalshimpi gopalshimpi requested a review from pkrawat1 May 24, 2018 19:45
@gopalshimpi gopalshimpi self-assigned this May 24, 2018
});
this.routernomal.navigateByUrl(urlTree);
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const queryMap = {
    Newest: 'updated_at+asc'
...}

sortFilter() {
       const urlTree = this.routernomal.createUrlTree([], {
         queryParams: { 'q[s]':  queryMap[this.selectedOption]},
         queryParamsHandling: 'merge',
         preserveFragment: true
       });
       this.routernomal.navigateByUrl(urlTree);
}

Copy link
Member

@pkrawat1 pkrawat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkrawat1 pkrawat1 merged commit 76cb865 into develop May 29, 2018
@pkrawat1 pkrawat1 deleted the sort-filters-157855828 branch May 29, 2018 05:09
pkrawat1 pushed a commit that referenced this pull request Jun 13, 2018
* Added Sort filters and Pretty_name
1. Added newest,alfabetical sorts.
2. Added Pretty name for selected category.

* Fixed Requested changes

* Added Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants