Credo powered improvements for monei #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeb
requested review from
kartikjagdale,
arjun289,
SagarKarwande and
chandradot99
oyeb
added
PR state: WIP
PR action: review
and removed
PR action: review
PR state: WIP
labels
Removed the pipes and spaces
oyeb
force-pushed
the
monei-tests-credo
branch
from
0b5043b
to
223726d
Compare
`paymentId` -> `payment_id`
* I had missed a few `paymentId`s. * Since #48 is merged, we can use full_name(). Coverage increased for free :)
SagarKarwande
approved these changes
Dec 27, 2017
pkrawat1
reviewed
Dec 27, 2017
lib/gringotts/gateways/monei.ex
Outdated
| :delete -> HTTPoison.delete(url <> "?" <> URI.encode_query(auth_params)) |> respond | ||
| end | ||
| network_response = case method do | ||
| :post -> HTTPoison.post(url, {:form, body}, @default_headers) |
There was a problem hiding this comment.
@oyeb we discussed formatting for this as per latest formatter code, make that change.
lib/gringotts/gateways/monei.ex
Outdated
| @@ -415,9 +416,10 @@ defmodule Gringotts.Gateways.Monei do | |||
| avs_result: [address: address, zip_code: zip_code], | |||
| raw: data] | |||
|
|
|||
There was a problem hiding this comment.
formatting for this should be something like
results = [
code: code,
description: result["description"],
]
test/gateways/monei_test.exs
Outdated
| end) | ||
| {:error, response} = Gateway.unstore("7214344252e11af79c0b9e7b4f3f6234", [config: auth]) | ||
| assert response.code == :undefined_response_from_monei | ||
| describe "unstore |" do |
* Fixed unstore test description * Example cards will expire in 82 yrs :P
pkrawat1
pushed a commit
that referenced
this pull request
Dec 28, 2017
* Refactored code as suggested by credo Closes #27 * Grouped tests using describe * Better test descriptions Removed the pipes and spaces * Renamed ia CamelCase var. `paymentId` -> `payment_id` * Renamed missed CamelCase var, improves CC coverage * I had missed a few `paymentId`s. * Since #48 is merged, we can use full_name(). Coverage increased for free :) * Ran the elixir 1.6 formatter on Monei * Fixed unstore test description * Example cards will expire in 82 yrs :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describecredo