[trexle] Adds Money protocol #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeb
changed the title
jyotigautam
changed the title
lib/gringotts/gateways/trexle.ex
Outdated
| @@ -39,7 +39,7 @@ defmodule Gringotts.Gateways.Trexle do | |||
| use Gringotts.Gateways.Base | |||
| use Gringotts.Adapter, required_config: [:api_key, :default_currency] | |||
There was a problem hiding this comment.
@oyeb since we are using money struct, is :default_currency is still required.
There was a problem hiding this comment.
No, it's not required.Will remove it from required config.
pkrawat1
requested changes
Jan 24, 2018
lib/gringotts/gateways/trexle.ex
Outdated
| authorized a payment worth $10 by referencing the obtained `charge_token`. | ||
|
|
||
| ``` | ||
| iex> amount = %{value: Decimal.new(10, :USD) |
There was a problem hiding this comment.
Not a correct amount format here.
lib/gringotts/gateways/trexle.ex
Outdated
|
|
||
| iex> Gringotts.capture(:payment_worker, Gringotts.Gateways.Trexle, token, amount) | ||
| ``` | ||
| iex> amount = %{value: Decimal.new(100, :USD) |
* test cases modified
* token and message added to Response * fixed examples * removed unnecessary tests and mocks
* Used `~s` sigils in mocks
jyotigautam
force-pushed
the
trexle_money
branch
from
e9b5a95
to
e697091
Compare
pkrawat1
pushed a commit
that referenced
this pull request
Jan 25, 2018
* Integrated Money protocol with trexle * token and message added to Response * Used `~s` sigils in mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
Money.to_integeras Trexle works in cents.ResponseRan the elixir 1.6 code formatter
~ssigils in mocks