shouldn't `function_filter` filter out all subsequent dynamic dispatches inside the ignored functions ?

[filchristou]

function_filter is filtering dynamic dispatch exactly on the functions specified.

Initially I thought I could ignore all subsequent analysis inside the ignored functions but this is not the case.

Can there by another argument that will enable ignoring all subsequent analysis inside given functions ?

E.g. Let's say I have the following functions

function entryfunction()
    a = typeunstable()
    return a
end

function typeunstable()
    a = [1, "ena", 1.0, true, :true, (1,2), (1,2,3)]
    randint = floor(Int, (rand() * 10) % length(a)) + 1
    ele = a[randint]
    return [ele ele]
end

I created typeunstable knowing that it will have type instabilities and I want to completely ignore it from the analysis.
However the following will still print errors:

function_filter_tu(@nospecialize f) = f !== typeunstable;
JET.@report_opt function_filter=function_filter_tu entryfunction()

What I should do to not get errors is

function_filter_hcat(@nospecialize f) = f !== hcat;
JET.@report_opt function_filter=function_filter_hcat entryfunction()

But this

• is tedious to specify
• will filter hcat out of other places that I might still want

[kbarros]

A similar problem was reported here:
https://discourse.julialang.org/t/jet-how-to-use-the-function-filter-argument/122470

There is a nice test case:

# This involves dynamic dispatch inside the call chain "string" -> ... -> "show" -> ...
f(x::T) where T = x > 0 ? 1 : error("illegal argument of type $T")

# Intention is to mask report of runtime dispatch below "show"
@report_opt function_filter = (g -> g !== show) f(1)

The output still has errors below show in the call stack. Is there a way to mask them?

 f(x::Int64) @ Main ./REPL[13]:1
│┌ string(::String, ::Type{Int64}) @ Base ./strings/io.jl:193
││┌ print_to_string(::String, ::Type{Int64}) @ Base ./strings/io.jl:151
│││┌ print(io::IOBuffer, x::DataType) @ Base ./strings/io.jl:35
││││┌ show(io::IOBuffer, x::DataType) @ Base ./show.jl:968
│││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:973
││││││┌ show_typealias(io::IOBuffer, x::Type) @ Base ./show.jl:810
│││││││┌ make_wheres(io::IOBuffer, env::Core.SimpleVector, x::Type) @ Base ./show.jl:776
││││││││┌ push!(s::IdSet{Any}, x::TypeVar) @ Base ./idset.jl:55
│││││││││┌ _assert_tostring(msg::Expr) @ Base ./error.jl:247
││││││││││ runtime dispatch detected: %1::Any(msg::Expr)::Any
│││││││││└────────────────────
││││││││┌ push!(s::IdSet{Any}, x::TypeVar) @ Base ./idset.jl:55
│││││││││ runtime dispatch detected: AssertionError(%52::Any)::AssertionError
││││││││└────────────────────
││││││││┌ push!(s::IdSet{Any}, x::TypeVar) @ Base ./idset.jl:64
│││││││││ runtime dispatch detected: AssertionError(%89::Any)::AssertionError
││││││││└────────────────────
│││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:976
││││││┌ show_datatype(io::IOBuffer, x::DataType) @ Base ./show.jl:1127
│││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1130
││││││││┌ maybe_kws_nt(x::DataType) @ Base ./show.jl:1118
│││││││││ runtime dispatch detected: eltype(%128::DataType)::Any
││││││││└────────────────────
│││││││┌ show_datatype(io::IOBuffer, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1205
││││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOBuffer, %352::Tuple, %351::DataType)::Any
│││││││└────────────────────
│││││┌ _show_type(io::IOBuffer, x::Type) @ Base ./show.jl:1010
││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1205
│││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOContext{IOBuffer}, %463::Tuple, %462::DataType)::Any
││││││└────────────────────
││││││┌ show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar}) @ Base ./show.jl:1213
│││││││ runtime dispatch detected: Base.show_at_namedtuple(io::IOContext{IOBuffer}, %561::Tuple, %573::DataType)::Any
││││││└────────────────────