chore(release-plz): give term-styles its own tag namespace#528
Merged
Conversation
release-plz has failed on every push to master since the term-styles workspace crate was introduced in #521. Without a per-package git_tag_name, release-plz falls back to the workspace-wide `v{{ version }}` template (the daft tag format), picks up the latest `v1.13.0` daft tag, and attributes it to term-styles. It then tries to read term-styles/Cargo.toml from a worktree checked out at v1.13.0 — where the crate doesn't exist yet — and aborts with "Failed to find package 'term-styles'". Mirror the xtask configuration: own tag template (`{{ package }}-v…`), `release = false`, `publish = false`, no changelog. release-plz now looks for `term-styles-v*` tags, finds none, treats the crate as never released, and skips it cleanly. Fixes #527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-plz.tomlentry forterm-stylesmirroring howxtaskis configured: own tag template ({{ package }}-v{{ version }}),release = false,publish = false, no changelog.term-stylesworkspace crate.Why this fixes it
Without a per-package
git_tag_name, release-plz uses the workspace-widev{{ version }}template — the daft tag format — for every crate it discovers. It then picks up the latestv1.13.0daft tag and attributes it toterm-styles:release-plz then tries to read
term-styles/Cargo.tomlfrom a worktree checked out at v1.13.0, where the crate doesn't exist yet (it was added after v1.13.0 was cut), and the run aborts.With a distinct tag template, release-plz looks for
term-styles-v*tags, finds none, treats the crate as never released, and skips it — same defensextaskalready uses.Fixes #527
Test plan
term-styles.daftor no-ops.🤖 Generated with Claude Code