Skip to content

chore(release-plz): give term-styles its own tag namespace#528

Merged
avihut merged 1 commit into
masterfrom
daft-527/fix-release-plz-term-styles
May 18, 2026
Merged

chore(release-plz): give term-styles its own tag namespace#528
avihut merged 1 commit into
masterfrom
daft-527/fix-release-plz-term-styles

Conversation

@avihut
Copy link
Copy Markdown
Owner

@avihut avihut commented May 18, 2026

Summary

  • Adds a per-package release-plz.toml entry for term-styles mirroring how xtask is configured: own tag template ({{ package }}-v{{ version }}), release = false, publish = false, no changelog.
  • Unblocks the Release-plz workflow on master, which has failed on every push since refactor(test-runner): introduce CommandExecutor port at runner/daft seam #521 introduced the term-styles workspace crate.

Why this fixes it

Without a per-package git_tag_name, release-plz uses the workspace-wide v{{ version }} template — the daft tag format — for every crate it discovers. It then picks up the latest v1.13.0 daft tag and attributes it to term-styles:

INFO Latest release of package term-styles: tag `v1.13.0` (version 1.13.0)
ERROR failed to update packages
    0: failed to determine next versions
    1: get cargo package term-styles from worktree at "/tmp/release-plz-term-styles-…/worktree"
    2: Failed to find package "term-styles"

release-plz then tries to read term-styles/Cargo.toml from a worktree checked out at v1.13.0, where the crate doesn't exist yet (it was added after v1.13.0 was cut), and the run aborts.

With a distinct tag template, release-plz looks for term-styles-v* tags, finds none, treats the crate as never released, and skips it — same defense xtask already uses.

Fixes #527

Test plan

  • Release-plz workflow run on this PR's branch parses the manifest without erroring out on term-styles.
  • After merge, the next push to master triggers a Release-plz run that completes successfully and either opens a release PR for daft or no-ops.

🤖 Generated with Claude Code

release-plz has failed on every push to master since the term-styles
workspace crate was introduced in #521. Without a per-package
git_tag_name, release-plz falls back to the workspace-wide
`v{{ version }}` template (the daft tag format), picks up the latest
`v1.13.0` daft tag, and attributes it to term-styles. It then tries to
read term-styles/Cargo.toml from a worktree checked out at v1.13.0 —
where the crate doesn't exist yet — and aborts with "Failed to find
package 'term-styles'".

Mirror the xtask configuration: own tag template (`{{ package }}-v…`),
`release = false`, `publish = false`, no changelog. release-plz now
looks for `term-styles-v*` tags, finds none, treats the crate as never
released, and skips it cleanly.

Fixes #527
@avihut avihut added this to the Public Launch milestone May 18, 2026
@avihut avihut added the chore Maintenance tasks label May 18, 2026
@avihut avihut self-assigned this May 18, 2026
@avihut avihut merged commit c8b1a38 into master May 18, 2026
10 checks passed
@avihut avihut deleted the daft-527/fix-release-plz-term-styles branch May 18, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release-plz fails on master: 'Failed to find package term-styles'

1 participant