v0.21.9.0 fix(host): reorder remoteEnvPrep so mise activates when binary is at ~/.local/bin

[avinashjoshi]

Summary

Fix for canopy host upgrade on hosts where the Go toolchain lives behind ~/.bashrc (mise/asdf activated only in interactive shells).

The v0.21.4.0 fix wrapped the remote shell in bash -l to source ~/.bash_profile / ~/.profile. That solved hosts whose toolchain is wired through login files, but on Omarchy/Arch/Ubuntu — where ~/.bashrc early-exits on [[ $- != *i* ]] && return — non-interactive bash never sources bashrc, mise never activates, and make install dies with make: go: No such file or directory.

This PR rewrites remoteEnvPrep in internal/ui/update_host_upgrade.go to bypass bashrc entirely: prepend static toolchain paths (~/.local/bin, /usr/local/go/bin, ~/go/bin) first, then eval "$(mise activate bash)" (now reachable because ~/.local/bin is on PATH), then source ~/.asdf/asdf.sh. The ordering is load-bearing: an earlier draft ran command -v mise BEFORE the static prepend, which silently missed mise installed via the canonical curl https://mise.run | sh (binary at ~/.local/bin/mise) — reproducing the original failure. Adversarial review caught it pre-merge.

Rebased onto current main (took v0.21.9.0 slot — v0.21.7.0 and v0.21.8.0 landed during review).

Test Coverage

remoteEnvPrep — branch coverage

Layer 1: static toolchain spots (runs first)
  [+] dir exists, not in PATH ........ covered  (RunsUnderBash, $HOME/go/bin)
  [+] dir exists, already in PATH .... covered  (DedupesPath, count==1)
  [~] dir missing .................... partial  (exercised, no assertion)

Layer 2: command -v mise && eval "$(mise activate bash)"
  [+] mise at ~/.local/bin/mise ...... covered  (ActivatesMiseInUserLocalBin — NEW)
  [+] mise absent .................... covered  (RunsUnderBash, DedupesPath)

Layer 3: . ~/.asdf/asdf.sh
  [+] asdf absent .................... covered  (RunsUnderBash, DedupesPath)

Static invariants
  [+] required substrings present .... covered  (Fragments)
  [+] both call sites chain prep ..... covered  (ChainEnvPrep)

Coverage: ~79% (9 covered + 1 partial / 12 branches). Tests: +5 new in internal/ui/update_host_upgrade_test.go.

Pre-Landing Review

No critical issues. 4 INFORMATIONAL specialist findings (conf 5-7) judged low-value cosmetics per project's "no premature abstraction" guideline. Adversarial review caught a real ordering bug — fixed in da91034, regression-pinned by TestRemoteEnvPrep_ActivatesMiseInUserLocalBin. PR Quality Score: 8/10.

Plan Completion

No plan file — this was reactive bug-fix work.

TODOS

No items completed.

Documentation

• docs/remote-workspaces.md: extended the U bullet under "Upgrading a remote" to explain mise/asdf direct activation.
• docs/troubleshooting.md: new entry for the make: go: No such file or directory failure mode with the fix (upgrade laptop canopy to v0.21.9.0+) and fallback if Go is installed outside the prepended locations.

Test plan

• go test ./... passes (cmd/canopy + all internal/* packages)
• go test -race ./internal/ui/ passes (new CI requirement from v0.21.8.0)
• TestRemoteEnvPrep_ActivatesMiseInUserLocalBin regression test passes; reverse the snippet order → test fails with clear diagnostic
• Empirical: snippet exits 0 on bare HOME; with mise at /usr/bin/mise surfaces shim PATH; with stubbed mise at ~/.local/bin/mise + PATH=/usr/bin:/bin activation runs and shim dir lands on PATH
• Field test: canopy host upgrade tower from TUI should succeed end-to-end (requires laptop canopy at v0.21.9.0+)

🤖 Generated with Claude Code