Improvements to letsencrypt_mgmt_profile.py #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using tenant with "*" breaks the script as it searches for the tenant, but doesn't find it. As per AVI Python SDK when no value is specified (so using None), it will fallback to the default tenant for the specified user.
Certificate is being checked by default.
As its ensured that the VS is listening on port 80 anyway, we don't need to only apply the rule to port 80. The advantage is following: When HTTP-to-HTTPS redirect is enabled in the ApplicationProfile/parent VirtualHosting, the rule for port 80 won't apply and token validation fails. Without this, it also works on HTTPS (443) and token verification succeeds (LetsEncrypt follows redirect from :80 to :443 for token validation)
This was quite tricky, as child-VH VSs use vh_domain_name and cannot be identified via fqdn and don't have services object in the result. Therefore, when child VS detected, we do a slightly different search for VSs and set the services object from the parent VS. This way the later logic is mainly untouched.
nikhilky
reviewed
Jun 9, 2021
Contributor
nikhilky
left a comment
nikhilky
left a comment
There was a problem hiding this comment.
Thanks for these enhancements. I had few comments
chitr
reviewed
Jun 21, 2021
chitr
reviewed
Jun 21, 2021
| keyauthorization = "{0}.{1}".format(token, thumbprint) | ||
|
|
||
| # Update vs | ||
| # Get VSVIPs/VSs, based on FQDN |
There was a problem hiding this comment.
Break this flow to smaller functions based on related functionality.
chitr
reviewed
Jun 21, 2021
chitr
reviewed
Jun 21, 2021
chitr
reviewed
Jun 21, 2021
| print ("Found vs {} with fqdn {}".format(vs_uuid, domain)) | ||
| # Check if the vs is servering on port 80 | ||
|
|
||
| # Let's check if VS is enabled, otherwise challenge can never successfully complete. |
There was a problem hiding this comment.
Lets move avi specific flow to separate function.(for next iteration )
Contributor
Author
|
I have had a chat with @nikhilky on this one. Main points:
I have tested the current version, the last commit, working well on the latest 21.1. There seems to be some issue when using multiple domains on one VS (basically using SANs) because of some restrictions of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
Virtual Hostingscenarios (SNI)Tested it with VH setup with SNI, RSA and ECDSA with a public-reachable test domain.