Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEA] When a subject is kept in Edit more for like around 5 mins it crashes because it is trying to fetch random things from s3. #1242

Closed
4 tasks
AchalaBelokar opened this issue Jun 10, 2024 · 4 comments
Assignees

Comments

@AchalaBelokar
Copy link

Describe the bug
When a subject is kept in Edit more for like around 5 mins it crashes because it is trying to fetch random things from s3. Even the calls should ve not been made

To Reproduce
Steps to reproduce the behavior:

  1. Login with maha@goonj
  2. edit the distribution
  3. wait for 5 min
  4. see the error on inspect

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
s3

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Developer Checklist(Developer fixing the bug should fill this checklist)

  • Does the fix require extensive regression testing?
    • Yes
    • No
  • Are you mentioning the required scenarios that could be affected?
    • Yes
    • No
@AchalaBelokar AchalaBelokar added the bug Something isn't working label Jun 10, 2024
@mahalakshme mahalakshme removed the bug Something isn't working label Jun 10, 2024
@mahalakshme mahalakshme changed the title When a subject is kept in Edit more for like around 5 mins it crashes because it is trying to fetch random things from s3. [DEA] When a subject is kept in Edit more for like around 5 mins it crashes because it is trying to fetch random things from s3. Jun 10, 2024
@himeshr himeshr self-assigned this Jun 10, 2024
himeshr added a commit to avniproject/rules-server that referenced this issue Jun 10, 2024
@mahalakshme
Copy link
Contributor

@himeshr still too many failing requests are there in prerelease - notes are also considered as media currently and tried to fetch

Image

/rules returning 400 bad request - so decisions not getting shown
Image

@himeshr
Copy link
Contributor

himeshr commented Jun 12, 2024

Issues here:

  1. Prerelease will not have prod media content, resulting in media fetch errors
  2. Notes is handled as media and tried to fetch // Can be fixed, not harmful for now
  3. rules api call for decisions is failing //Point of concern, needs handling in-depth
  4. any eligibilityCheck was failing due to token invalid error and crashing the app //Fixed as part of this card

@AchalaBelokar
Copy link
Author

  • I am login with taqim@sncu and search with individual and try to edit the child followup ...rule is failing there

Image

@vinayvenu vinayvenu reopened this Jun 18, 2024
@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 18, 2024

@AchalaBelokar we didn't address all issues in DEA. But is the above working in prod, if so then we need to fix it. Else out of scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants