Support date and date_time to clear the value#1108
Merged
adrianthedev merged 2 commits intoJul 29, 2022
Merged
Conversation
|
Code Climate has analyzed commit 036ff6c and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 523 523
Lines 10388 10388
=======================================
Hits 9784 9784
Misses 604 604
Continue to review full report at Codecov.
|
Comment on lines
+257
to
+269
| nullable_fields = fields | ||
| .filter do |field| | ||
| field.nullable | ||
| end | ||
| .map do |field| | ||
| [field.id, field.null_values] | ||
| end | ||
| [field.id, field.null_values] | ||
| end | ||
| .to_h | ||
|
|
||
| params.each do |key, value| | ||
| nullable = nullable_fields[key.to_sym] | ||
| nullable_values = nullable_fields[key.to_sym] | ||
|
|
||
| if nullable.present? && value.in?(nullable) | ||
| if nullable_values.present? && value.in?(nullable_values) |
Collaborator
There was a problem hiding this comment.
minor formatting here
Collaborator
|
Thank you for the fix @rickychilcott |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While updating the date/date_time picking implementation, we lost the ability to set the value to empty.
Previously, there was an avo date_field_controller.js exception that was raise that would bail out of the
onChangewhen the input field was empty.Manual review steps
dateordate_timefieldManual reviewer: please leave a comment with output from the test if that's the case.