Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: resource actions #112

Merged
merged 18 commits into from Aug 18, 2020
Merged

feature: resource actions #112

merged 18 commits into from Aug 18, 2020

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Aug 17, 2020

Draft PR. Do not merge.

app/controllers/avo/actions_controller.rb Outdated Show resolved Hide resolved
spec/requests/avo/actions_request_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@mihaimdm22 mihaimdm22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work! Besides actions, the refactoring was needed as well. Would need a call to deeply understand how actions work.

app/frontend/js/components/BooleanCheck.vue Show resolved Hide resolved
app/frontend/js/Avo.js Show resolved Hide resolved
app/frontend/js/mixins/has-forms.js Show resolved Hide resolved
lib/avo/app/action.rb Show resolved Hide resolved
lib/avo/app/resource_fields.rb Show resolved Hide resolved
@adrianthedev adrianthedev merged commit c0b1f1e into master Aug 18, 2020
@adrianthedev adrianthedev deleted the feature/actions-2 branch August 18, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants