feature: Callable readonly#1150
Merged
adrianthedev merged 2 commits intoAug 19, 2022
Merged
Conversation
|
Code Climate has analyzed commit 0ee683a and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportBase: 94.18% // Head: 94.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
+ Coverage 94.18% 94.27% +0.08%
==========================================
Files 530 549 +19
Lines 10560 10967 +407
==========================================
+ Hits 9946 10339 +393
- Misses 614 628 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
Author
|
The failing test appears unrelated to me. |
Collaborator
|
This looks good too! Again, I'll do a manual check tmr! Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for making the
readonlyfield take a proc, just like required (implemented in #955)Checklist:
With support from @ncsmith24