Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: stacked fields by default #1349

Merged
merged 4 commits into from Oct 24, 2022
Merged

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Oct 24, 2022

Description

It allows a developer to set some fields or all of them in a stacked layout instead of inline.

CleanShot 2022-10-24 at 12 49 13

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Go to the initializer and edit the field_wrapper_layout option to :stacked
  2. See the show and edit views for a resource
  3. observe that all the fields are stacked

  1. Reset the initializer to how it was (:inline)
  2. Go to the user and observe that only the first_name field is stacked. The rest are inline.

Manual reviewer: please leave a comment with output from the test if that's the case.

@codeclimate
Copy link

codeclimate bot commented Oct 24, 2022

Code Climate has analyzed commit ecfbc55 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@adrianthedev adrianthedev merged commit e26aec7 into main Oct 24, 2022
@adrianthedev adrianthedev deleted the feature/stacked-fields branch October 24, 2022 11:38
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant