Skip to content

Make placeholder and help callable#1406

Merged
adrianthedev merged 5 commits into
avo-hq:mainfrom
rickychilcott:feature/make-placeholder-and-help-callable
Nov 8, 2022
Merged

Make placeholder and help callable#1406
adrianthedev merged 5 commits into
avo-hq:mainfrom
rickychilcott:feature/make-placeholder-and-help-callable

Conversation

@rickychilcott

@rickychilcott rickychilcott commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Description

This will make the help and placeholder fields callable.

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@qlty-cloud-legacy

qlty-cloud-legacy Bot commented Nov 7, 2022

Copy link
Copy Markdown

Code Climate has analyzed commit bee0a18 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev

Copy link
Copy Markdown
Collaborator

Hey @rickychilcott. Thanks for this PR. We're trying to make all callable blocks around Avo adhere to execute from an isolated place. More explanations about that here.

Would you be willing to refactor this PR to reflect that using the changes in this PR? Specifically, this line here is what I'm talking about.

@adrianthedev adrianthedev merged commit 7275231 into avo-hq:main Nov 8, 2022
@adrianthedev adrianthedev added the Enhancement Not necessarily a feature, but something has improved label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Not necessarily a feature, but something has improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants