feature: Allow Avo::NavigationLinkComponent to accept an optional target param#685
Merged
adrianthedev merged 1 commit intoavo-hq:mainfrom Feb 19, 2022
Conversation
While working on adding out some custom tools, some of the items I'm linking to are provided by other gems (Sidekiq, PGHero, etc.) and I'd like to pop them in new windows. This option will allow me to specify a target of _blank.
|
Code Climate has analyzed commit e5f4b9e and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #685 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 364 364
Lines 6535 6536 +1
=======================================
+ Hits 6128 6129 +1
Misses 407 407
Continue to review full report at Codecov.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on adding out some custom tools, some of the items I'm linking to are provided by other gems (Sidekiq, PGHero, etc.) and I'd like to pop them in new windows. This option will allow me to specify a target of
_blank.Checklist: