Skip to content

feature: Allow Avo::NavigationLinkComponent to accept an optional target param#685

Merged
adrianthedev merged 1 commit intoavo-hq:mainfrom
rickychilcott:feature/expand-navigation-link-component
Feb 19, 2022
Merged

feature: Allow Avo::NavigationLinkComponent to accept an optional target param#685
adrianthedev merged 1 commit intoavo-hq:mainfrom
rickychilcott:feature/expand-navigation-link-component

Conversation

@rickychilcott
Copy link
Copy Markdown
Contributor

@rickychilcott rickychilcott commented Feb 19, 2022

Description

While working on adding out some custom tools, some of the items I'm linking to are provided by other gems (Sidekiq, PGHero, etc.) and I'd like to pop them in new windows. This option will allow me to specify a target of _blank.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

While working on adding out some custom tools, some of the items I'm linking to are provided by other gems (Sidekiq, PGHero, etc.) and I'd like to pop them in new windows. This option will allow me to specify a target of _blank.
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit e5f4b9e and detected 0 issues on this pull request.

View more on Code Climate.

@rickychilcott rickychilcott changed the title Allow Avo::NavigationLinkComponent to accept an optional target param feature: Allow Avo::NavigationLinkComponent to accept an optional target param Feb 19, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2022

Codecov Report

Merging #685 (e5f4b9e) into main (b061927) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files         364      364           
  Lines        6535     6536    +1     
=======================================
+ Hits         6128     6129    +1     
  Misses        407      407           
Impacted Files Coverage Δ
app/components/avo/navigation_link_component.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b061927...e5f4b9e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants