Rails 7 deprecates Date#to_s in favor of Date#to_formatted_s#774
Merged
adrianthedev merged 1 commit intoApr 2, 2022
Merged
Conversation
|
Code Climate has analyzed commit 9134252 and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
Author
|
If this is merged. Any chance it can get backported to a 1.x release? I'm planning to upgrade to 2.x soon-ish, but I'm trying to get to Rails 7 in my app first. |
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 430 430
Lines 7861 7861
=======================================
Hits 7396 7396
Misses 465 465
Continue to review full report at Codecov.
|
Collaborator
|
Thanks @rickychilcott. I'll cut a release after we merge it. |
4 tasks
Contributor
Author
|
attempted in #775 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a deprecation warning in Rails 7 where dates should be formatted using
to_formatted_swhen passing a named format type.Checklist:
Manual review steps
Tried in my existing app and everything seems fine.
to_ssimply forwarded toto_formatted_s, so it's a benign change.