Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support Libvirt package build test #1581

Merged
merged 1 commit into from Nov 20, 2018

Conversation

@sathnaga
Copy link
Contributor

commented May 22, 2018

The patch implements the build capability for avocado-vt for libvirt sources
from the git repository. The implemention is to get libvirt git repo and make
binaries and build rpms and install as part of the build test.

Signed-off-by: Shivaprasad G Bhat sbhat@linux.vnet.ibm.com
Signed-off-by: Satheesh Rajendran sathnaga@linux.vnet.ibm.com

@sathnaga

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2018

@sathnaga

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2018

# avocado run --vt-config /home/sath/avocado-fvt-
wrapper/data/avocado-vt/backends/libvirt/cfg/build.cfg
JOB HTML   : /home/sath/avocado-fvt-wrapper/results/job-2018-05-22T13.06-1835341/results.html
JOB ID     : b8ab8c1d3f462a55e3f06517940c196901d87dde
JOB LOG    : /home/sath/avocado-fvt-wrapper/results/job-2018-05-22T13.06-b8ab8c1/job.log
 (1/1) build: PASS (518.34 s)
@@ -324,6 +329,21 @@ def _install_phase_init_verify(self):
"""
pass

def _install_phase_package(self):
"""
"""

This comment has been minimized.

Copy link
@balamuruhans

balamuruhans Jun 4, 2018

Member

can document the todo action if we are keeping it for future work.

Run "make rpm"
"""
os.chdir(self.build_dir)
process.system("make rpm")

This comment has been minimized.

Copy link
@balamuruhans

balamuruhans Jun 4, 2018

Member

how do we ensure make rpm succeeded or got error out

This comment has been minimized.

Copy link
@sathnaga

sathnaga Oct 1, 2018

Author Contributor

process.system will error out and should result in test failure

This comment has been minimized.

Copy link
@sathnaga

sathnaga Oct 4, 2018

Author Contributor

one more check even if the make rpm silently give false success, this should catch _install_phase_package_verify

import os
import platform
from avocado.utils import process
import base_installer

This comment has been minimized.

Copy link
@balamuruhans

balamuruhans Jun 4, 2018

Member

one line space between builtin, framework packages,

It is better to import base_installer as,

from virttest import base_installer

def _install_phase_init_verify(self):
"""
Check if package install is success

This comment has been minimized.

Copy link
@balamuruhans

balamuruhans Jun 4, 2018

Member

this is not been met by the method as the return value is not asserted to ensure it is success or failure.
This is common across all the methods

This comment has been minimized.

Copy link
@sathnaga

sathnaga Oct 1, 2018

Author Contributor

sure,

This comment has been minimized.

Copy link
@sathnaga

sathnaga Oct 4, 2018

Author Contributor

this would directly produce a test fail incase of failure...

"""
Create libvirt package
"""
if os.path.isdir("/root/rpmbuild/"):

This comment has been minimized.

Copy link
@balamuruhans

balamuruhans Jun 4, 2018

Member

It is not good to hardcode path.

This comment has been minimized.

Copy link
@sathnaga

sathnaga Oct 1, 2018

Author Contributor

let me add a param with default value to it...

Added support Libvirt package build test
The patch implements the build capability for avocado-vt for libvirt sources
from the git repository. The implemention is to get libvirt git repo and make
binaries and build rpms and install as part of the build test.

Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com>
Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>

@sathnaga sathnaga force-pushed the sathnaga:libvirt_installer branch from 3af8f3a to 74fbe0c Oct 4, 2018

@balamuruhans balamuruhans merged commit 40df218 into avocado-framework:master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.