Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow escaping values defined in "docstring statements" such as tags #4541

Open
clebergnu opened this issue Apr 21, 2021 · 1 comment
Open
Labels
customer:QEMU Requirements/issues raised by the QEMU project enhancement

Comments

@clebergnu
Copy link
Contributor

Time and time again we expand the definition of the DOCSTRING_DIRECTIVE_RE_RAW in an attempt to allow for more descriptive tags.

This time there's an argument in favor of allowing commas to be used as part of tag values.

To cover this and future use cases, let's evaluate (and if possible) come up with a general and universal way of escaping characters in the docstring statements.

@clebergnu clebergnu added enhancement customer:QEMU Requirements/issues raised by the QEMU project labels Apr 21, 2021
@clebergnu clebergnu added this to the #88 (The Serpent) milestone Apr 21, 2021
@clebergnu clebergnu added this to Long Term Backlog in Avocado Kanban via automation Apr 21, 2021
@wainersm
Copy link
Contributor

It is hard to keep backward compatibility.

Possible solutions:

  1. Introduce a "tag_separator" tag where the user can specify the separator character (e.g the -d option of cut).
    Advantages: suppose only a few tests need a non-commas separator, so you have fine-grained control
    Disadvantages: the other way around, all tests need this new separator, so you end-up with "tag_separator" everywhere
  2. Allow the user to define the separator on any avocado.conf file. It would need to allow a avocado.conf at the project-level because, IIRC, currently that file can live at system or user's home only. The advantages/disadvantages are the inverse of 1), so maybe the two solutions could coexist.

@clebergnu clebergnu modified the milestones: #89 (Shrek), #90 (TBD) Jun 21, 2021
@richtja richtja removed this from the #90 (Blade Runner) milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer:QEMU Requirements/issues raised by the QEMU project enhancement
Projects
Avocado Kanban
  
Long Term (Next Q) Backlog
Status: Long Term (Next Q) Backlog
Development

No branches or pull requests

3 participants