assets: warn the user when a hash is not provided #4539
Conversation
|
This improvement raised from a discussion on QEMU: https://www.mail-archive.com/qemu-devel@nongnu.org/msg800013.html |
There was a problem hiding this comment.
Hi @wainersm thank you for this. This is very welcome. Just one small suggestion and we are good to go.
IMO, the entire asset think must be redesigned, and we are planning to do this soon. I have a blueprint to write and @clebergnu is doing another one and hopefully, they will be in alignment.
If the Asset.fetch() caller does not provide a hash for the asset then it is not possible to check its integrity. Problems may arise from using corrupted files. So let's log a message warning the user about it. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
wainersm
force-pushed
the
assets_no_hash_msg
branch
from
a38183e
to
2f2ffa4
Compare
|
Just updated the commit with:
|
|
Code Climate has analyzed commit 2f2ffa4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.3% (0.0% change). View more on Code Climate. |
|
@richtja @beraldoleal the failed tests on travis-ci seems not related with my changes. Is this job known to fail intermittently? |
|
@wainersm Yes this is known Travis issue. Thanks for the changes. |
If the Asset.fetch() caller does not provide a hash for the asset then
it is not possible to check its integrity. Problems may arise from using
corrupted files. So let's log a message warning the user about it.
Signed-off-by: Wainer dos Santos Moschetta wainersm@redhat.com