Improve portability #5622
Merged
Improve portability #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asserts being made conditional here assume that a Linux system was used during the test execution, so that the contents of "/proc/cmdline" and "/proc/meminfo" were available. Let's skip those on non-Linux platforms. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Some systems do not have a /bin/true and /bin/false binaries. While we could use "passtest.py" and "failtest.py", sometimes we want to test the exec-test bits too. This introduces a substitute for /bin/true that are used when the environment is not certain, in contrast with some /bin/true references that can be found on CI configuration files when the execution is pinned to a certain system type. Signed-off-by: Cleber Rosa <crosa@redhat.com>
Instead of raising a FileNotFoundError when attempting to get a list of all modules by reading /proc/modules, if it's not available, let's return an empty list (and log that fact). The main reason is this is used indirectly by higher level functionality, such as decorators to skip tests in environments where there is no Linux module functionality, so it needs to behave a bit nicer. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
improve_portability
branch
from
d33b41e
to
fd2508d
Compare
This improves considerably the scope of test under OS X. There are a few issues pending that would allow for the complete execution of the selftests, but this is a good first step IMO. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
improve_portability
branch
from
fd2508d
to
5bb81bd
Compare
richtja
approved these changes
Mar 15, 2023
|
Good stuff, @clebergnu, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This improves portability on UNIX systems that are not necessarily your run-of-the-mill Linux distros.
In this case, a good part of the selftests gets to be run macOS.