virtualenv: allow tests to run properly on them #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While going through the dependency list (requirements*.txt files) and performing our self tests out of virtual environments, I noticed that some tests are run outside the virtual environments. The reason is that, even though the virtual environment is activated for the test session (and say, `which python` gives `/venv/bin/python`), we have hard coded `/usr/bin/python` in most places. According to the some discussions on the virtualenv project itself[1], a quick solution is to revert to the also common `/usr/bin/env python` way of pointing to the Python interpreter. [1] - pypa/virtualenv#124 Signed-off-by: Cleber Rosa <crosa@redhat.com>
|
Yep, good catch. I verified by fgrep that it covers all occurrences. |
ldoktor
added a commit
that referenced
this pull request
Dec 7, 2015
virtualenv: allow tests to run properly on them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the dependency list (requirements*.txt files) and
performing our self tests out of virtual environments, I noticed that
some tests are run outside the virtual environments.
The reason is that, even though the virtual environment is activated
for the test session (and say,
which pythongives/venv/bin/python),we have hard coded
/usr/bin/pythonin most places.According to the some discussions on the virtualenv project itself[1],
a quick solution is to revert to the also common
/usr/bin/env pythonway of pointing to the Python interpreter.
[1] - pypa/virtualenv#124
Signed-off-by: Cleber Rosa crosa@redhat.com