Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercom 'id' of undefined #1338

Closed
kolundzija opened this issue Mar 22, 2017 · 9 comments
Closed

Intercom 'id' of undefined #1338

kolundzija opened this issue Mar 22, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@kolundzija
Copy link

@kolundzija kolundzija commented Mar 22, 2017

IMPORTANT: Please try to describe how did it happen.


App v. 2.13.0
Avocode UID: 16313

TypeError: Cannot read property 'id' of undefined
    at p (https://js.intercomcdn.com/frame.82487f3e.js:1:24870)
    at c (https://js.intercomcdn.com/frame.82487f3e.js:5:17723)
    at https://js.intercomcdn.com/frame.82487f3e.js:5:18024
    at Array.map (native)
    at https://js.intercomcdn.com/frame.82487f3e.js:5:18001
    at https://js.intercomcdn.com/frame.82487f3e.js:2:22592
    at https://js.intercomcdn.com/frame.82487f3e.js:2:22028
    at p (https://js.intercomcdn.com/frame.82487f3e.js:2:22797)
    at https://js.intercomcdn.com/frame.82487f3e.js:2:22756
    at Array.map (native)
    at p (https://js.intercomcdn.com/frame.82487f3e.js:2:22731)
    at Array.<anonymous> (https://js.intercomcdn.com/frame.82487f3e.js:18:2332)
    at l (https://js.intercomcdn.com/frame.82487f3e.js:9:14700)
    at https://js.intercomcdn.com/frame.82487f3e.js:18:450
    at https://js.intercomcdn.com/frame.82487f3e.js:17:24948
    at https://js.intercomcdn.com/frame.82487f3e.js:17:31789
    at https://js.intercomcdn.com/frame.82487f3e.js:17:23420
    at https://js.intercomcdn.com/frame.82487f3e.js:17:31432
    at https://js.intercomcdn.com/frame.82487f3e.js:29:14875
    at onUserPresent (https://js.intercomcdn.com/frame.82487f3e.js:5:15445)
    at HTMLDocument.l (https://js.intercomcdn.com/frame.82487f3e.js:18:3285)
    at HTMLDocument.wrapped (/Applications/Avocode.app/Contents/Resources/app.asar/node_modules/raven-js/src/raven.js:283:29)
@vojtatranta vojtatranta added this to the 2.13.1 milestone Mar 22, 2017
@vojtatranta
Copy link

@vojtatranta vojtatranta commented Mar 22, 2017

This should be fixed in 2.13.1 releasing today.

@jakubzitny jakubzitny added this to the 2.13.2 milestone Mar 28, 2017
@jakubzitny jakubzitny removed this from the 2.13.1 milestone Mar 28, 2017
@jakubzitny
Copy link
Member

@jakubzitny jakubzitny commented Mar 28, 2017

Hi @kolundzija, we've not been able to fix this problem yet. We're investigating it right now. It is happening to some users but we are not sure why exactly, so any further details you might have could help us.

We hope the fix should be ready in one of the next releases.

@jakubzitny jakubzitny changed the title Unknown Error Intercom 'id' of undefined Mar 28, 2017
@jakubzitny jakubzitny mentioned this issue Mar 28, 2017
@petrbrzek petrbrzek added this to the 2.13.5 milestone Apr 11, 2017
@petrbrzek petrbrzek removed this from the 2.13.2 milestone Apr 11, 2017
@petrbrzek petrbrzek mentioned this issue Apr 11, 2017
@connor-bean connor-bean mentioned this issue Apr 12, 2017
@jakubzitny
Copy link
Member

@jakubzitny jakubzitny commented Jul 13, 2017

This should be fixed in latest version of Avocode, so I'll close this thread. Feel free to open a new issue if you have more problems with Avocode 😉

@jakubzitny jakubzitny closed this Jul 13, 2017
@laander
Copy link

@laander laander commented Jul 21, 2017

@jakubzitny Would you mind sharing how you fixed it?

I'm not using avocode TBH, but we experienced it in our product and I can't for the life of me figure out why it's happening. Maybe related to the Segment integration?
segment-integrations/analytics.js-integration-intercom#24

@jakubzitny
Copy link
Member

@jakubzitny jakubzitny commented Jul 21, 2017

I think @vojtatranta might know better.

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Jul 23, 2017

@laander try catch....

@laander
Copy link

@laander laander commented Aug 1, 2017

@vojtatranta But try-catch what? It seems like it's an internal error happening inside the Intercom lib, most likely because it's passed some problematic data, no?

@bitdivision
Copy link

@bitdivision bitdivision commented Aug 29, 2017

I'd also be very interested in a fix if @vojtatranta has any more details, or if @laander has since fixed it?

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Aug 29, 2017

@bitdivision I wrapped calls to Intercom in try / catch and hoped that error does not happening asynchronously:

try {
      if (params) {
        this._window.Intercom(actionType, params)
      } else {
        this._window.Intercom(actionType)
      }
    } catch (err) {
      if (this._track) {
        this._track.trackError(err, {
          captured: true,
        })
      }
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants