Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design load time & crash #1829

Closed
sarates opened this issue Jan 23, 2018 · 15 comments
Closed

Design load time & crash #1829

sarates opened this issue Jan 23, 2018 · 15 comments

Comments

@sarates
Copy link

@sarates sarates commented Jan 23, 2018

Design exported by sketch. It took me 10 mins to download 92% of file and Avocode freeze at 4059 / 4392

Avocode 2.18.0

http://i.prntscr.com/VrjyQavZRbSPml2n6Yt8hQ.png

@sarates sarates changed the title Design load time Design load time & crash Jan 23, 2018
@crh225
Copy link

@crh225 crh225 commented Jan 23, 2018

@sarates we have large designs also. Just curious, do all of your files take that long to download?

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Jan 23, 2018

Oh, you've got a design with 4400 bitmaps in it?

@jakubzitny jakubzitny added this to the 2.19.0 milestone Jan 24, 2018
@jakubzitny
Copy link
Member

@jakubzitny jakubzitny commented Jan 24, 2018

Hi guys, we'll be releasing much faster rendering engine in 2.19.0. Right now it's available on web and it will be available in desktop app in 2.19.0. Rendering large designs with a lots of layers should be faster and you will not need to "download" all the assets before opening the design. You can try this already on app.avocode.com.

@crh225
Copy link

@crh225 crh225 commented Jan 25, 2018

Im using 2.19.0 in the web and it takes 30 seconds to render an design with only 250 layers.
image

@crh225
Copy link

@crh225 crh225 commented Jan 25, 2018

Now looking in the console, it says you may have an eventEmitter memory leak.
image

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

2.19.0 was released, this should be fixed

@vojtatranta vojtatranta closed this Feb 7, 2018
@crh225
Copy link

@crh225 crh225 commented Feb 7, 2018

@vojtatranta this is not fixed

@vojtatranta vojtatranta reopened this Feb 7, 2018
@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

@crh225 alrighty, can you send that original file?

@crh225
Copy link

@crh225 crh225 commented Feb 7, 2018

I cannot as I am not a designer put I can send you an example avocode link?

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

@crh225 yes, please send me the privat link (just copy url in the browser of that design) Via. email vojtatranta@avocode.com thanks :)

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

:) ok, thanks

@avocode avocode deleted a comment from crh225 Feb 7, 2018
@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

Aha, it's a sketch file. That's pitty, we cannot access them. You must send it to us, otherwise I cannot debug it :(

@crh225
Copy link

@crh225 crh225 commented Feb 7, 2018

@vojtatranta you can close ticket. Our designer is remote, so it is difficult for us to get the sketch file. I will email you once we get the sketch file.

Thank you!

@vojtatranta
Copy link

@vojtatranta vojtatranta commented Feb 7, 2018

@crh225 we changed the way how designs are opened in the 2.19.0 but in order to make it work properly, you'd have to reupload that design to try out.

@jakubzitny jakubzitny modified the milestones: 2.19.0, 3.0 Feb 26, 2018
@jakubzitny jakubzitny modified the milestones: 3.0, 2.22.0 Mar 20, 2018
@jakubzitny jakubzitny modified the milestones: 2.22.0, 2.23.0, 2.24.0 Apr 4, 2018
@jakubzitny jakubzitny removed this from the 2.24.0 milestone Apr 18, 2018
@jakubzitny jakubzitny added this to the 3.0 milestone Apr 18, 2018
@jakubzitny jakubzitny modified the milestones: 3.0, 2.25.0 Apr 30, 2018
@jakubzitny
Copy link
Member

@jakubzitny jakubzitny commented May 2, 2018

Hi @sarates and @crh225, we've improved design opening/loading time in latest Avocode 2.25.0. Please update and let us know if you have any related problems or ideas for improvements 😉

@jakubzitny jakubzitny closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants