New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading XD file with special characters doesn't work #1835

Closed
desir2web opened this Issue Jan 24, 2018 · 19 comments

Comments

Projects
None yet
3 participants
@desir2web

desir2web commented Jan 24, 2018


  • Version: 2.18.2
  • Sketch plugin version: 48.2.0
  • Web/Desktop: Desktop
  • Platform: darwin
  • Avocode UID: 255176

Error: Failed to open Adobe XD CC design in 20000ms.
    at file:///Applications/Avocode.app/Contents/Resources/app.asar/dist/avocode.min.js:1:3819334
    at wrapped (/Applications/Avocode.app/Contents/Resources/app.asar/node_modules/@avocode/stage/node_modules/raven-js/src/raven.js:351:21)
@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Hi @desir2web, thanks for reporting this issue. Which version of Adobe XD do you have please? Did you try uploading by dragging and dropping a .xd file to Avocode or did you try the XD menu option Export -> Avocode?

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

Export -> Avocode, Browse Files and drag-n-drop: same result with large file (81mb)
For small file export works fine.

@jakubzitny jakubzitny added the xd label Jan 24, 2018

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

Just a minute ago have the same issue with small file. https://github.com/avocode/avocode/files/1660083/Test.Avocode.XD.xd.zip

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

Using the latest versions if Avocode and Xd

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Thanks for the file and info, this is weird though. Avocode is waiting 20s for "response" from XD. If the communication works correctly, the size should not matter. Can you try reseting both XD and Avocode, closing all "other" documents in XD (leave open just the one you want to sync) and just try the Export -> Avocode trigger? Are you always getting the 20000ms error?

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

yep, unfortunately it happens again and again (even after reseting and only with 1 file opened in Xd)

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Ohh, I think I know what the issue here is, sorry about that. It's the + in the filename. Please rename the file and it should work correctly. We will definitely fix this for the next version.

@jakubzitny jakubzitny added bug and removed waitingForUser labels Jan 24, 2018

@jakubzitny jakubzitny changed the title from Wow, just from the 1st try — fail, but I believe in you, guys :D to Uploading XD file with special characters doesn't work Jan 24, 2018

@jakubzitny jakubzitny added the upload label Jan 24, 2018

@jakubzitny jakubzitny self-assigned this Jan 24, 2018

@jakubzitny jakubzitny added this to the 2.19.0 milestone Jan 24, 2018

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

Yeah, you were right. Also import process ignore the art-boards with + in the title

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

But works fine with , = and &

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Really? The artboard with + that you sent worked for me actually, after I renamed the file. We ignore some artboard on purpose though, the ones that start with _ or -.

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

oh, now it works)) but the larger file don't have any + mentions in file name or art-boards name still show the timeout error

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Would you mind sharing the larger design too? If you don't want it to be public you can send it to team@avocode.com.

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

Sorry but I can't — NDA

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

How about trying this one? It's a 91MB XD file, can you please try if that works for you?

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

This one works fine, seems like it depends on art-boarts count. In my file there are more then 500+ art-boards :D

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Allright, we've tested around 200, we'll test more artboards for the next release and hopefully fix your problem.

@desir2web

This comment has been minimized.

desir2web commented Jan 24, 2018

630 — this is exact current count of art-boards... As an suggestion: set the timeout depending on art-boards count, if it possible to get this info from Xd. Anyway, thank you guys for help.

@jakubzitny

This comment has been minimized.

Member

jakubzitny commented Jan 24, 2018

Yes it is, the timeout is only for the initial "connection" to XD, not for actually fetching the data, so I think we should be able to fix this.

Thanks for you help! We'll let you know when the new update is available 😉

@vojtatranta

This comment has been minimized.

vojtatranta commented Feb 7, 2018

2.19.0 was released, this should be fixed

@vojtatranta vojtatranta closed this Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment