Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bourbon size mixin error #424

Closed
filipemerker opened this issue Sep 1, 2015 · 7 comments
Closed

Bourbon size mixin error #424

filipemerker opened this issue Sep 1, 2015 · 7 comments

Comments

@filipemerker
Copy link

@filipemerker filipemerker commented Sep 1, 2015

There is an error into the Bourbon sass mixin library generator.
It generates this

@include size(305px, 400px);

When it must be

@include size(305px 400px); /*without the comma*/

For the record, follows the gulp trown error:

{ message: 'assets/scss/partials/_home.scss\n  249:18  mixin size only takes 1 arguments; given 2',
  column: 18,
  line: 249,
  file: '/www/.../assets/scss/partials/_home.scss',
  status: 1,
  messageFormatted: '\u001b[4massets/scss/partials/_home.scss\u001b[24m\n\u001b[90m  249:18\u001b[39m  mixin size only takes 1 arguments; given 2',
  name: 'Error',
  stack: 'Error: assets/scss/partials/_home.scss\n  249:18  mixin size only takes 1 arguments; given 2\n    at options.error (/www/.../node_modules/gulp-sass/node_modules/node-sass/lib/index.js:276:32)',
  showStack: false,
  showProperties: true,
  plugin: 'gulp-sass' }

@victorhramos
Copy link

@victorhramos victorhramos commented Sep 1, 2015

+1

@AlexanderPlaksenko
Copy link

@AlexanderPlaksenko AlexanderPlaksenko commented Sep 10, 2015

@filipemerker
Copy link
Author

@filipemerker filipemerker commented Oct 19, 2015

Com'on guys, this is an easy one that really bothers me and every Bourbon user ever! @rychlis @marekhrabe @petrbrzek

@petrbrzek petrbrzek added the bug label Oct 19, 2015
@petrbrzek
Copy link
Member

@petrbrzek petrbrzek commented Oct 19, 2015

@filipemerker Will be fixed in the next release.

@petrbrzek petrbrzek self-assigned this Oct 23, 2015
@petrbrzek petrbrzek added this to the 2.5.0 - Eternal Sunshine of the Spotless Mind milestone Oct 25, 2015
petrbrzek added a commit to csshat/language-sass that referenced this issue Oct 25, 2015
@petrbrzek
Copy link
Member

@petrbrzek petrbrzek commented Nov 10, 2015

We've launched Avocode 2.4.4 beta which should fix this issue, you can download the build from here:

​Mac - https://manager.avocode.com/download/app-beta/mac/

Linux ia32 - https://manager.avocode.com/download/app-beta/linux-ia32/
​Linux x64 - https://manager.avocode.com/download/app-beta/linux/
​Windows - https://manager.avocode.com/download/app-beta/windows/

This will remain in beta for now, if everything goes fine we will enable auto-update to 2.4.4 globally

@rychlis
Copy link
Member

@rychlis rychlis commented Nov 12, 2015

Avocode 2.4.5 is now live with the fix. Let us know if you still experience the same issue and we will re-open the issue

@rychlis rychlis closed this Nov 12, 2015
@filipemerker
Copy link
Author

@filipemerker filipemerker commented Nov 12, 2015

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants