Skip to content

recognize iterable type by constructor reference for serialization #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2017
Merged

recognize iterable type by constructor reference for serialization #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 30 additions & 8 deletions src/serialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,40 @@ function replaceRecord(rec, replaceChild) {
return { "__record": rec._name, "data": recordData }
}

function getIterableType(iterable) {
switch (iterable.constructor) {
case immutable.List:
return 'List'

case immutable.Set:
return 'Set'

case immutable.OrderedSet:
return 'OrderedSet'

case immutable.Stack:
return 'Stack'

case immutable.Map:
return 'Map'

case immutable.OrderedMap:
return 'OrderedMap'

default:
return undefined
}
}


function replaceIterable(iter, replaceChild) {
debug('replaceIterable()', iter)

const iterableType = iter.constructor.name
const iterableType = getIterableType(iter)
Copy link
Collaborator

@jankuca jankuca Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To se klidně mohl jen upravit ten switch tady.

Copy link
Contributor Author

@vojtatranta vojtatranta Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no já potřebuju ten string pro tu serializaci, takže jsem to udělal přes metodu

Copy link
Collaborator

@jankuca jankuca Jan 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach tak, jasně, jsem vůl. Ok.

if (!iterableType) {
throw new Error(`Cannot find type of iterable: ${iter}`)
}

switch (iterableType) {
case 'List':
case 'Set':
Expand All @@ -156,13 +185,6 @@ function replaceIterable(iter, replaceChild) {
mapData.push([ key, replaceChild(key, value) ])
})
return { "__iterable": iterableType, "data": mapData }

default:
const iterData = {}
iter.forEach((value, key) => {
iterData[key] = replaceChild(key, value)
})
return { "__iterable": iterableType, "data": iterData }
}
}

Expand Down