Another MBB reordering bug #62
Closed
Comments
gergoerdi
added a commit
to gergoerdi/llvm-avr
that referenced
this issue
May 20, 2017
…e same spot as the original MBB (avr-rust/rust-legacy-fork#62)
|
This seems fixable with the exact same change as I did on the |
|
While the IR from my original comment works with this change, it now breaks
|
|
To reproduce with gergoerdi/llvm-avr@f7931de:
but I have a movie to catch RN :) |
gergoerdi
added a commit
to gergoerdi/llvm-avr
that referenced
this issue
May 20, 2017
…e same spot as the original MBB (avr-rust/rust-legacy-fork#62)
|
Hah, commit simply had a bug where I forgot to remove the old |
|
Looks like the fix is in avr-rust/llvm#2 |
gergoerdi
added a commit
to gergoerdi/llvm-avr
that referenced
this issue
Jun 17, 2017
…e same spot as the original MBB (avr-rust/rust-legacy-fork#62)
gergoerdi
added a commit
to gergoerdi/llvm-avr
that referenced
this issue
Jun 18, 2017
…e same spot as the original MBB (avr-rust/rust-legacy-fork#62)
dylanmckay
added a commit
to avr-rust/llvm
that referenced
this issue
Sep 24, 2017
…e same spot as the original MBB (avr-rust/rust-legacy-fork#62)
|
My |
|
Committed in r314180. |
chapuni
pushed a commit
to llvm-project/llvm-project-20170507
that referenced
this issue
Sep 26, 2017
…e same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi.
chapuni
pushed a commit
to llvm-project/llvm
that referenced
this issue
Sep 26, 2017
…e same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@314180 91177308-0d34-0410-b5e6-96231b3b80d8
earl
pushed a commit
to earl/llvm-mirror
that referenced
this issue
Sep 26, 2017
…e same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@314180 91177308-0d34-0410-b5e6-96231b3b80d8
chapuni
pushed a commit
to llvm-project/llvm-project-submodule
that referenced
this issue
Sep 26, 2017
…e same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi.
jyknight
pushed a commit
to jyknight/llvm-monorepo
that referenced
this issue
Sep 28, 2017
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------ llvm-svn=314383
chapuni
pushed a commit
to llvm-project/llvm
that referenced
this issue
Sep 28, 2017
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_50@314383 91177308-0d34-0410-b5e6-96231b3b80d8
chapuni
pushed a commit
to llvm-project/llvm-project-20170507
that referenced
this issue
Jan 8, 2018
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------
chapuni
pushed a commit
to llvm-project/llvm-project-submodule
that referenced
this issue
Jan 8, 2018
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------
llvm-git-migration
pushed a commit
to llvm-git-prototype/llvm
that referenced
this issue
Nov 6, 2018
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------ llvm-svn=314383
llvm-git-migration
pushed a commit
to llvm-git-prototype/llvm
that referenced
this issue
Jan 4, 2019
------------------------------------------------------------------------ r314180 | dylanmckay | 2017-09-26 13:51:03 +1300 (Tue, 26 Sep 2017) | 7 lines [AVR] When lowering shifts into loops, put newly generated MBBs in the same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. ------------------------------------------------------------------------ llvm-svn: 314383
JohnHolmesII
pushed a commit
to JohnHolmesII/llvm-project
that referenced
this issue
Oct 12, 2020
…e same spot as the original MBB Discovered in avr-rust/rust-legacy-fork#62 avr-rust/rust-legacy-fork#62 Patch by Gergo Erdi. llvm-svn: 314180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This one seems similar to #49. I don't have a shrunk example yet.
LLVM IR:
In the generated assembly,
mainstarts with%startas expected, but then falls through to%"_ZN75_$LT$chip8_avr..Board$u20$as$u20$chip8_engine..peripherals..Peripherals$GT$12scan_key_row17haa3ed42a3d3a5068E.exit.i"instead of%bb2.i:The text was updated successfully, but these errors were encountered: