Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct license URL #143

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@chabala
Copy link
Contributor

chabala commented Oct 7, 2019

The license URL in the pom should be an actual URL. This is perhaps overly pedantic of me, but I noticed after adding awaitility to my project that it showed up in the broken links report for the maven site.

Here's a public example of the problem (not my usage): https://strengthened.github.io/prometheus-healthchecks/dependencies.html

  • In the dependency list the license shows up as LICENSE.txt, no title, not a link.
  • In the dependency graph, where nodes expand by clicking the icons, there's a link titled Apache 2.0 but it links to LICENSE.txt in the generated site for that project, which doesn't exist.

Using a real URL solves both these issues.

@johanhaleby johanhaleby merged commit 99959ea into awaitility:master Oct 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johanhaleby

This comment has been minimized.

Copy link
Collaborator

johanhaleby commented Oct 7, 2019

Thank you!

@chabala chabala deleted the chabala:fix-license-url branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.