Test for issue #32

[nkitchen]

This test file contains the case I posted in the issue thread.

[awalterschulze]

Perfect thank you

…

On Fri, 9 Jun 2017, 05:25 Nathan Kitchen, ***@***.***> wrote: This test file contains the case I posted in the issue thread. ------------------------------ You can view, comment on, or merge this pull request online at: #33 Commit Summary - Test for issue #32 File Changes - *A* issue32_test.go <https://github.com/awalterschulze/gographviz/pull/33/files#diff-0> (55) Patch Links: - https://github.com/awalterschulze/gographviz/pull/33.patch - https://github.com/awalterschulze/gographviz/pull/33.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#33>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvsLbL9538pzItTVPBGtjdkbjjuNB0Tks5sCLsogaJpZM4N03I4> .

[awalterschulze]

Do you want to contribute this fix in the pull request as well?

diff --git a/attrs.go b/attrs.go
index a00eeb7..5e1518a 100644
--- a/attrs.go
+++ b/attrs.go
@@ -56,9 +56,7 @@ func (attrs Attrs) Extend(more Attrs) {
 // Ammend only adds the missing attributes to attrs Attrs type.
 func (attrs Attrs) Ammend(more Attrs) {
        for key, value := range more {
-               if _, ok := attrs[key]; !ok {
-                       attrs.add(key, value)
-               }
+               attrs.add(key, value)
        }
 }

[nkitchen]

Your suggested fix just makes Ammend the same as Extend. Is that really what you intended?

[awalterschulze]

Good spot, yes maybe I just want to rather call extend and remove the ammend method. I seems that ammend is not really what you ever want to do.

[nkitchen]

Yes, I came to basically the same conclusion after adding several more test cases. In fact, the proposed fix that I will send includes changing Nodes.Add to call Extend.

[awalterschulze]

Great work :)
I think this is ready to merge and you?

[nkitchen]

Yes, I believe this completely resolves the issue.