Include Normal Data default on #172

Closed
JohnBrookes opened this Issue Jun 15, 2013 · 3 comments

2 participants

@JohnBrookes

Just tested a file and got flat shading after export.
Realised theres an option "Include Normal Data"

If the AwayBuilder view is using normal data then this should be on. Or at least default on.

@80prozent 80prozent was assigned Jun 15, 2013
@80prozent
Away Tools member

Hi john
I will set the default for the normals to true. I think having this option to depent on the awaybuilder scengraph might get messy. Sometimes you want to explizit exlude normals from export. If the option woukd change automaticcly when importing a file, it might be confusing.....

@80prozent
Away Tools member

I have been thinking about this again.
It might be best, only to export normalData, if the "includeNormals"=true and if the "autoDeriveNormalData" of a Subgeometry is "false".
This way we do not end up exporting unnecessary normalData.
To make this happen, we would need to add the "autoDeriveNormalData" to the SubGeometryVO. (SubGeometryVO.autoDeriveNormalData)
I think it would make sense to do this for normals and for tangents.

@80prozent 80prozent added a commit that referenced this issue Jun 19, 2013
@80prozent 80prozent Fix #177 + #172 + add ogre.awd 2e63607
@80prozent
Away Tools member

I added the autoDeriveNormals and autoDerivetangents to the SubGeometryVO.
Changed default for "includeNormals" and "includeTangents" to true, but only export them if they are not autoderived.

@80prozent 80prozent closed this Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment