New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced lodash.flattendeep with lodash #17

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@chhavin
Copy link

chhavin commented Feb 6, 2019

PR for issue : Min lodash version should be updated to 4.17.5 #16

@chhavin

This comment has been minimized.

Copy link
Author

chhavin commented Feb 6, 2019

@aweary Can you please review. Thanks.

@ljharb
Copy link

ljharb left a comment

If were replacing this, let’s replace it with https://npmjs.com/array.prototype.flat instead

@aweary

This comment has been minimized.

Copy link
Owner

aweary commented Feb 7, 2019

Yeah I don't want to pull in all of lodash just for this

Show resolved Hide resolved src/grammar.ne Outdated
@ljharb

ljharb approved these changes Feb 12, 2019

@chhavin

This comment has been minimized.

Copy link
Author

chhavin commented Feb 19, 2019

Can someone with write access please merge the changes @ljharb @aweary . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment