More gravity-related changes #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the code in here first handled clients changing its x/y position and afterwards it handled resizes. This meant that the special case of "client resizes without moving itself so we need to apply gravity" had to have special checks on whether the client moved itself or not. Change the code so that resizes are handled first and moves later. This naturally handles the problem: If the client resizes and moves itself, the move done for the resize is later overwritten when the move is handled. No functional changes are intended. Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
The function window_set_border_width() causes its own gravity handling. Thus, to make sure that this gravity handling does not interfere with what the code in here does later, we just apply changes to the border width first, and then do everything else. Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
c->size_hints.win_gravity only contains something valid if the XCB_ICCCM_SIZE_HINT_P_WIN_GRAVITY bit is set in the flags. Most likely this wasn't noticed before, because most code just happens to zero-initialize this field and gravity 0 is NorthWest, which does not do anything. Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
+ Coverage 84.03% 84.11% +0.08%
==========================================
Files 477 478 +1
Lines 32671 34448 +1777
==========================================
+ Hits 27454 28976 +1522
- Misses 5217 5472 +255
|
Elv13
approved these changes
Aug 26, 2018
actionless
approved these changes
Sep 6, 2018
|
@psychon Is this ready to merge now or do you plan to do the "other half" of the gravity issues you mentioned in the first comment along with merging this? |
I tried fixing those bugs a couple of times already and never got anywhere... :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still none of the bugs reported by @sigprof are fixed, but here are some more gravity-related changes that hopefully simplify the code (and an unrelated bugfix is in here as well).