New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ga into __gaTracker [Finishes #79837148] #115

Merged
merged 4 commits into from Oct 23, 2014

Conversation

Projects
None yet
6 participants
@andizer
Contributor

andizer commented Oct 17, 2014

Fixes #107

andizer and others added some commits Oct 17, 2014

Merge branch 'trunk' into stories/AM/rename_ga_object
Conflicts:
	admin/pages/extensions.php

omarreiss added a commit that referenced this pull request Oct 23, 2014

Merge pull request #115 from Yoast/stories/AM/rename_ga_object
Changed ga into __gaTracker [Finishes #79837148]

@omarreiss omarreiss merged commit 34ab06c into trunk Oct 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@omarreiss omarreiss deleted the stories/AM/rename_ga_object branch Oct 23, 2014

@lkraav

This comment has been minimized.

lkraav commented Nov 13, 2014

What if I don't want the __gaTracker change breaking my customer's site? Legacy systems may have ga() calls piled up everywhere.

Why no filter to override the tracker variable name if needed?

Right now I'm just putting this into Custom code box:

var ga = __gaTracker;

Is this enough?

@adamgross42

This comment has been minimized.

adamgross42 commented on bcd70a6 Dec 7, 2014

What is the purpose of using a non-standard function name?

This comment has been minimized.

meganedesigns replied Mar 4, 2015

The changing the function name ga() to __gaTracker() breaks event logging. What is the purpose of using __gaTracker() instead of the function Google recommends: ga()?

This comment has been minimized.

philipjfulcher replied Oct 2, 2015

Was it ever explained why this change was made? We had trouble with an third-party vendor's tracking scripts because of this.

This comment has been minimized.

lkraav replied Oct 2, 2015

Nope. This was just made, with no explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment