Orders with no payments show ammount_paid==0 #171

merged 3 commits into from Sep 12, 2012


None yet
3 participants

twoolie commented Aug 30, 2012

This is not C. Returning -1 is counter-intuitive and will lead to data problems unless it is explicitly dealt with everywhere this is touched.


chrisglass commented Aug 31, 2012

Seems very rational. What was I thinking?

Thanks a lot!


chrisglass commented Aug 31, 2012

Yeah so actually, this is not C: we have unit tests :)

And this change breaks the test suite.

twoolie added some commits Sep 1, 2012

@twoolie twoolie Alter test for amount_paid: never return -1 43dca06
@twoolie twoolie Overpaid is still paid.
Changes the test for whether something has been paid for to allow for overpayment.

twoolie commented Sep 1, 2012

So I've updated the only test I could see that would fail due to changes. Please let me know if it works for you.


chrisglass commented Sep 11, 2012

Well, here is how to test that your branch works: ./runtests.sh

If you see a F in there (like with your latest commits), it means the suite fails.

So yeah, it still fails.

@alesdotio alesdotio pushed a commit to alesdotio/django-shop that referenced this pull request Sep 12, 2012

Ales Kocjancic fixed api tests for #171 ab08938

@alesdotio alesdotio merged commit 7967c9d into awesto:master Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment