Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amplify Analytics - Backfill Missing Unit Tests #162

Closed
fjnoyp opened this issue Oct 24, 2020 · 0 comments
Closed

Amplify Analytics - Backfill Missing Unit Tests #162

fjnoyp opened this issue Oct 24, 2020 · 0 comments
Assignees
@ragingsquirrel3
Labels
analytics Issues related to the Amplify Analytics Category feature-request A request for a new feature or an enhancement to an existing API or category. good first issue Good for newcomers requires-ios-fix This issue is the result of an underlying Amplify iOS issue that needs to be fixed.

Comments

@fjnoyp
Copy link
Contributor

fjnoyp commented Oct 24, 2020

Problem Statement:
The current unit tests for Analytics do not fully cover all cases and platforms.

  1. Expand dart unit tests to test the serialization of input data types. Test using "expect" that these input data types are serialized correctly when being sent over the method channel.

  2. Add iOS unit tests.

These new tests should follow the implementation of unit tests for the Datastore Query API.

This is a good first issue for someone looking to contribute to this repo.
@fjnoyp fjnoyp added feature-request A request for a new feature or an enhancement to an existing API or category. good first issue Good for newcomers analytics Issues related to the Amplify Analytics Category requires-ios-fix This issue is the result of an underlying Amplify iOS issue that needs to be fixed. labels Oct 24, 2020
@ragingsquirrel3 ragingsquirrel3 mentioned this issue Apr 16, 2021
Merged
@ragingsquirrel3 ragingsquirrel3 self-assigned this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ragingsquirrel3 ragingsquirrel3

Labels
analytics Issues related to the Amplify Analytics Category feature-request A request for a new feature or an enhancement to an existing API or category. good first issue Good for newcomers requires-ios-fix This issue is the result of an underlying Amplify iOS issue that needs to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ragingsquirrel3 @fjnoyp