From 7da18bfb9939cf7ed89b418c02a7186937387f4c Mon Sep 17 00:00:00 2001
From: Eddie Keller <keledwin@amazon.com>
Date: Wed, 26 May 2021 13:21:49 -0700
Subject: [PATCH] chore: adding in thrown errors on certain cloudwatch
 operations

---
 .../__tests__/Providers/AWSCloudWatchProvider-test.ts |  2 +-
 packages/core/src/Providers/AWSCloudWatchProvider.ts  | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/packages/core/__tests__/Providers/AWSCloudWatchProvider-test.ts b/packages/core/__tests__/Providers/AWSCloudWatchProvider-test.ts
index 9e1ec5d8484..877cd873b88 100644
--- a/packages/core/__tests__/Providers/AWSCloudWatchProvider-test.ts
+++ b/packages/core/__tests__/Providers/AWSCloudWatchProvider-test.ts
@@ -76,7 +76,7 @@ describe('AWSCloudWatchProvider', () => {
 				});
 			};
 
-			await expect(action()).rejects.toThrowError();
+			expect(action()).rejects.toThrowError();
 			spyon.mockRestore();
 		});
 	});
diff --git a/packages/core/src/Providers/AWSCloudWatchProvider.ts b/packages/core/src/Providers/AWSCloudWatchProvider.ts
index b48b11a981d..c8c5e18a1df 100644
--- a/packages/core/src/Providers/AWSCloudWatchProvider.ts
+++ b/packages/core/src/Providers/AWSCloudWatchProvider.ts
@@ -125,6 +125,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return output;
 		} catch (error) {
 			logger.error(`error creating log group - ${error}`);
+			throw error;
 		}
 	}
 
@@ -147,6 +148,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return output;
 		} catch (error) {
 			logger.error(`error getting log group - ${error}`);
+			throw error;
 		}
 	}
 
@@ -171,6 +173,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return output;
 		} catch (error) {
 			logger.error(`error creating log stream - ${error}`);
+			throw error;
 		}
 	}
 
@@ -192,6 +195,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return output;
 		} catch (error) {
 			logger.error(`error getting log stream - ${error}`);
+			throw error;
 		}
 	}
 
@@ -213,6 +217,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return output;
 		} catch (error) {
 			logger.error(`error getting log events - ${error}`);
+			throw error;
 		}
 	}
 
@@ -260,6 +265,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 		} catch (err) {
 			const errString = `failure during log group search: ${err}`;
 			logger.error(errString);
+			throw err;
 		}
 	}
 
@@ -303,6 +309,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 		} catch (err) {
 			const errString = `failure during log stream search: ${err}`;
 			logger.error(errString);
+			throw err;
 		}
 	}
 
@@ -384,6 +391,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			return this._nextSequenceToken;
 		} catch (err) {
 			logger.error(`failure while getting next sequence token: ${err}`);
+			throw err;
 		}
 	}
 
@@ -429,6 +437,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 				});
 			} else {
 				this._dataTracker.eventUploadInProgress = false;
+				throw err;
 			}
 		}
 	}
@@ -493,7 +502,7 @@ class AWSCloudWatchProvider implements LoggingProvider {
 			);
 			this._dataTracker.eventUploadInProgress = false;
 
-			throw Error;
+			throw err;
 		}
 	}