Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add type="email" to input field when usernameAttribute=email #4199

merged 2 commits into from Oct 18, 2019


Copy link

Issue #, if available:

Description of changes:
By setting the input field type to email, we make the browser's and input devices' jobs easier by suggesting this is an email field. Visible changes are;
-Email address suggestions from browser
-Tablet devices pop-up keyboards with lowercase letters as default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #4199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4199   +/-   ##
  Coverage   71.59%   71.59%           
  Files         166      166           
  Lines       10023    10023           
  Branches     2021     2021           
  Hits         7176     7176           
  Misses       2501     2501           
  Partials      346      346
Impacted Files Coverage Δ
packages/aws-amplify-react/src/Auth/AuthPiece.tsx 87.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c20630...9595611. Read the comment docs.

@Amplifiyer Amplifiyer merged commit 0269812 into aws-amplify:master Oct 18, 2019
@Amplifiyer Amplifiyer self-assigned this Oct 18, 2019
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants