Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Component - Fix keydown press. #5525

Merged
merged 1 commit into from Apr 23, 2020

Conversation

ashika01
Copy link
Contributor

@ashika01 ashika01 commented Apr 23, 2020

Issue #, if available:
fix #5512

Description of changes:

Refactoring back to onInput because of the following.

change events fire when the user commits a value change to a form control. This may be done, for example, by clicking outside of the control or by using the Tab key to switch to a different control.

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onchange

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika01 ashika01 requested a review from jordanranz Apr 23, 2020
@ashika01 ashika01 self-assigned this Apr 23, 2020
@ashika01 ashika01 requested review from ericclemmons and removed request for jordanranz Apr 23, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 23, 2020

Codecov Report

Merging #5525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5525   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         197      197           
  Lines       11531    11531           
  Branches     2173     2251   +78     
=======================================
  Hits         8409     8409           
+ Misses       2971     2951   -20     
- Partials      151      171   +20     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee185e1...ac38208. Read the comment docs.

@ashika01 ashika01 merged commit 388f04e into aws-amplify:master Apr 23, 2020
5 checks passed
@ashika01 ashika01 deleted the bug/fix-keydown-input branch Apr 23, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Jun 11, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants