Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/release to master #5526

Merged
merged 3 commits into from Apr 23, 2020
Merged

Fix/release to master #5526

merged 3 commits into from Apr 23, 2020

Conversation

elorzafe
Copy link
Contributor

@elorzafe elorzafe commented Apr 23, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@iartemiev iartemiev left a comment

LGTM

Copy link
Contributor

@sammartinez sammartinez left a comment

LGTM 🌮

@codecov
Copy link

@codecov codecov bot commented Apr 23, 2020

Codecov Report

Merging #5526 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5526   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files         197      197           
  Lines       11531    11531           
  Branches     2251     2173   -78     
=======================================
  Hits         8409     8409           
- Misses       2951     2971   +20     
+ Partials      171      151   -20     
Impacted Files Coverage Δ
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388f04e...3303f3e. Read the comment docs.

@elorzafe elorzafe merged commit 5177a07 into master Apr 23, 2020
5 checks passed
@iartemiev iartemiev deleted the fix/release-to-master branch Apr 24, 2020
@iartemiev iartemiev restored the fix/release-to-master branch Apr 24, 2020
@iartemiev iartemiev deleted the fix/release-to-master branch Apr 29, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Jun 11, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants