Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@aws-amplify/ui-components): Open up slot for sign-in/up footer #5603

Merged
merged 12 commits into from Apr 30, 2020

Conversation

jordanranz
Copy link
Contributor

@jordanranz jordanranz commented Apr 28, 2020

Issue #, if available:
#5594

Description of changes:

  • Slot API for customizing footer and it's content
  • Can be used to override default primary and secondary footer content

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jordanranz jordanranz requested a review from ericclemmons Apr 28, 2020
@ashika01
Copy link
Contributor

@ashika01 ashika01 commented Apr 28, 2020

@jordanranz Whats the reason for wrapping them in Host component?

Copy link
Contributor

@ericclemmons ericclemmons left a comment

This should resolve that customer's need! Nothing blocking, aside from any caveats around styling @ashika01 may have more context with.

Great work @jordanranz !

@ashika01 ashika01 self-assigned this Apr 28, 2020
@jordanranz
Copy link
Contributor Author

@jordanranz jordanranz commented Apr 29, 2020

Wrapping them in Host isn't needed for this PR, it is just better practice. That being said if there were styling issues due to using Host I am curious what caused that.

Copy link
Contributor

@ashika01 ashika01 left a comment

LGTM 👍 Lets do some spike on Host and styling and makes notes and share across so we have an idea :)

@jordanranz jordanranz merged commit 5ebdab7 into aws-amplify:master Apr 30, 2020
4 checks passed
@jordanranz jordanranz deleted the more-slots branch Apr 30, 2020
@ErikCH ErikCH added UI and removed Amplify UI Components labels May 19, 2021
@github-actions
Copy link

@github-actions github-actions bot commented May 20, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants