Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (aws-amplify-react-native) : analytics warning/error when using auth module #5629

Merged
merged 1 commit into from Apr 30, 2020

Conversation

ashika01
Copy link
Contributor

@ashika01 ashika01 commented Apr 30, 2020

Issue #, if available: fixes #4824

Description of changes:

Checking if the analytics module is configured before making the call for record similar to this implementation

This will be revisited with rewrite of auth modules in react native.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@amhinson amhinson left a comment

I've been meaning to look into why this was happening. Awesome 👍

@codecov
Copy link

@codecov codecov bot commented Apr 30, 2020

Codecov Report

Merging #5629 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5629   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files         197      197           
  Lines       11536    11536           
  Branches     2178     2178           
=======================================
  Hits         8412     8412           
  Misses       2971     2971           
  Partials      153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2482e1...c2f6f68. Read the comment docs.

Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Thanks for the fix. LGTM 🚀

@ashika01 ashika01 merged commit 41fb52c into aws-amplify:master Apr 30, 2020
5 checks passed
@ashika01 ashika01 deleted the bug-rn/fix-analytics-warning branch Apr 30, 2020
@nihp
Copy link

@nihp nihp commented May 21, 2020

@ashika01 This error is still there for me while Auth.signIn. I have upgraded to the latest version No credentials, applicationId or region

I am in the latest version.

"aws-amplify": "^3.0.11",
"aws-amplify-react-native": "^4.1.2",

@ashika01
Copy link
Contributor Author

@ashika01 ashika01 commented May 21, 2020

@nihp can you post a screenshot of your error log?

@nihp
Copy link

@nihp nihp commented May 22, 2020

Kindly refer the attached image for the error

Simulator_Screen_Shot_iPhone_11_2020_05_22_at_10_19_40

@nihp
Copy link

@nihp nihp commented May 26, 2020

@ashika01 Any updates

@dpickut
Copy link

@dpickut dpickut commented Jan 19, 2021

Any update on this? I'm running into the same problem using:
Expo SDK 40
aws-amplify@3.3.14
aws-amplify-react-native@4.3.0

I can log into Cognito and logout fine. The warning throws at the login process.

And, I checked the network request in the debugger. The header for the POST request that throws this error is directed to the correct IdentifyPoolId, but it lacks an authorization token. The malformed request seems to be coming from node_modules/react-dev-tools-core/dist/backend.js.

Thanks!

@github-actions
Copy link

@github-actions github-actions bot commented Jan 20, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants