Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking wording and punctuation for readability. #5634

Merged
merged 1 commit into from Apr 30, 2020

Conversation

weisisheng
Copy link
Contributor

@weisisheng weisisheng commented Apr 30, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

@codecov codecov bot commented Apr 30, 2020

Codecov Report

Merging #5634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5634   +/-   ##
=======================================
  Coverage   72.91%   72.91%           
=======================================
  Files         197      197           
  Lines       11536    11536           
  Branches     2256     2178   -78     
=======================================
  Hits         8412     8412           
- Misses       2951     2971   +20     
+ Partials      173      153   -20     
Impacted Files Coverage Δ
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 66.86% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts 35.55% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts 17.33% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41fb52c...0e0d9ec. Read the comment docs.

Copy link
Contributor

@ashika01 ashika01 left a comment

Thanks for your contribution 👍 Looks good will get this merged in.

@ashika01 ashika01 merged commit 8f03e22 into aws-amplify:master Apr 30, 2020
5 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Jun 11, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants