Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate .editorconfig and move to root #7780

Merged
merged 1 commit into from Feb 19, 2021

Conversation

iartemiev
Copy link
Contributor

This should correctly indent our PRs in GitHub automatically (instead of having to manually append ?ts=2 in the URL)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 LGTM

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #7780 (896bf1b) into main (94d6dff) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7780   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files         214      214           
  Lines       13410    13410           
  Branches     2628     2628           
=======================================
  Hits         9934     9934           
  Misses       3277     3277           
  Partials      199      199           
Impacted Files Coverage Δ
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0498885...896bf1b. Read the comment docs.

@iartemiev iartemiev merged commit aecdf3c into aws-amplify:main Feb 19, 2021
@iartemiev iartemiev deleted the root-editorconfig branch February 19, 2021 17:47
dgonsan pushed a commit to dgonsan/amplify-js that referenced this pull request Mar 18, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants