Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back crypto-browserify to 1.0.9 #857

Merged
merged 1 commit into from May 18, 2018

Conversation

powerful23
Copy link
Contributor

@powerful23 powerful23 commented May 17, 2018

Issue #, if available:
After upgrading to 3.0.0, we found it causes errors in Angular 6 and react native
Description of changes:
Rollback to the previous version. Will try to replace crypto-browserify with sjcl

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

@codecov-io codecov-io commented May 18, 2018

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #857   +/-   ##
======================================
  Coverage    87.3%   87.3%           
======================================
  Files          77      77           
  Lines        3670    3670           
  Branches      696     696           
======================================
  Hits         3204    3204           
  Misses        443     443           
  Partials       23      23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d74f4...a8a88b4. Read the comment docs.

@mlabieniec mlabieniec merged commit e6b86c0 into aws-amplify:master May 18, 2018
1 check passed
@powerful23 powerful23 deleted the rollback-crypto branch May 23, 2018
rasfra pushed a commit to epidemicsound/amplify-js that referenced this issue Mar 11, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Jun 12, 2021

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants