-
Notifications
You must be signed in to change notification settings - Fork 227
fix(datastore): Regression bug caused by changing the public enum value #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
palpatim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor style updates, otherwise LGTM
Amplify/Categories/DataStore/Model/Internal/Schema/ModelSchema+Definition.swift
Outdated
Show resolved
Hide resolved
Amplify/Categories/DataStore/Model/Internal/Schema/ModelSchema+Definition.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+AnyModelWithSync.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+AnyModelWithSync.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+AnyModelWithSync.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+AnyModelWithSync.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+AnyModelWithSync.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLRequest/GraphQLRequest+Model.swift
Outdated
Show resolved
Hide resolved
…LRequest+Model.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…+Definition.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…+Definition.swift Co-authored-by: Tim Schmelter <schmelte@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 64.80% 64.91% +0.11%
==========================================
Files 861 862 +1
Lines 34096 34184 +88
==========================================
+ Hits 22095 22192 +97
+ Misses 12001 11992 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Issue: #882
Description of changes: Regression bug caused by changing the public enum value
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.