Skip to content

Conversation

@royjit
Copy link
Contributor

@royjit royjit commented Nov 11, 2020

Issue: #882
Description of changes: Regression bug caused by changing the public enum value

  • Added static functions inside enum to match the previous enum cases to make it backward compatible.
  • Unit tests for the changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@royjit royjit changed the title fix(datastore): Regression bug caused by chaning the public enum value fix(datastore): Regression bug caused by changing the public enum value Nov 11, 2020
@royjit royjit self-assigned this Nov 11, 2020
Copy link
Member

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor style updates, otherwise LGTM

royjit and others added 8 commits November 11, 2020 09:22
…LRequest+Model.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…LRequest+AnyModelWithSync.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…+Definition.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
…+Definition.swift

Co-authored-by: Tim Schmelter <schmelte@amazon.com>
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #883 (b98dc7f) into main (85a8870) will increase coverage by 0.11%.
The diff coverage is 67.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
+ Coverage   64.80%   64.91%   +0.11%     
==========================================
  Files         861      862       +1     
  Lines       34096    34184      +88     
==========================================
+ Hits        22095    22192      +97     
+ Misses      12001    11992       -9     
Flag Coverage Δ
API_plugin_unit_test 62.56% <ø> (+0.07%) ⬆️
Analytics_plugin_unit_test 72.38% <ø> (ø)
Auth_plugin_unit_test 15.79% <ø> (ø)
DataStore_plugin_unit_test 83.05% <80.00%> (ø)
Predictions_plugin_unit_test 42.11% <ø> (ø)
Storage_plugin_unit_test 74.74% <ø> (ø)
build_test_amplify 64.35% <67.34%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...DataStore/Model/Internal/Schema/Model+Schema.swift 27.77% <ø> (ø)
.../DataStore/Model/Internal/Schema/ModelSchema.swift 88.23% <ø> (+5.88%) ⬆️
...n/Storage/SQLite/StorageEngineAdapter+SQLite.swift 75.47% <ø> (ø)
...Model/Internal/Schema/ModelField+Association.swift 41.30% <30.00%> (+38.22%) ⬆️
...reCategoryPlugin/Storage/SQLite/Model+SQLite.swift 78.02% <50.00%> (ø)
...Model/Internal/Schema/ModelSchema+Definition.swift 65.51% <72.72%> (+1.23%) ⬆️
...ryTests/DataStore/ModelFieldAssociationTests.swift 85.96% <85.96%> (ø)
...ugin/Storage/SQLite/SQLStatement+CreateTable.swift 91.89% <100.00%> (ø)
...oryPlugin/Storage/SQLite/SQLStatement+Select.swift 95.50% <100.00%> (ø)
...ests/TestSupport/Mocks/TestModelRegistration.swift 96.29% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a8870...3766da8. Read the comment docs.

@royjit royjit merged commit 30b3aa9 into main Nov 11, 2020
@royjit royjit deleted the royjit/fixmodelfield branch November 11, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants