fix(auth): Fix an issue where the fetchAuthSession callback is called twice #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #922 +/- ##
==========================================
- Coverage 67.29% 67.27% -0.03%
==========================================
Files 895 895
Lines 35389 35391 +2
==========================================
- Hits 23814 23808 -6
- Misses 11575 11583 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
palpatim
reviewed
Dec 1, 2020
Member
palpatim
left a comment
palpatim
left a comment
There was a problem hiding this comment.
Minor change requested to future proof the guard a bit
|
|
||
| awsMobileClient.getIdentityId().continueWith { (task) -> Any? in | ||
| guard task.error == nil else { | ||
| if let urlError = task.error as NSError?, urlError.domain == NSURLErrorDomain { |
Member
There was a problem hiding this comment.
nit: consider mutually exclusive if/else block here to ensure you return from each condition
palpatim
approved these changes
Dec 1, 2020
palpatim
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.