Skip to content

fix(auth): Fix an issue where the fetchAuthSession callback is called twice #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2020
Merged

fix(auth): Fix an issue where the fetchAuthSession callback is called twice #922

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c6f71e
fix(auth): Fix an issue where the fetchAuthSession callback is called…
royjit Dec 1, 2020
c2cb2b8
Updated as per PR comments
royjit Dec 1, 2020
308c9c3
Remvoed extra line
royjit Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions ...s/Auth/AWSCognitoAuthPlugin/Dependency/AuthorizationProviderAdapter+SignedInSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,19 +152,24 @@ extension AuthorizationProviderAdapter {
completionHandler: @escaping SessionCompletionHandler) {

awsMobileClient.getIdentityId().continueWith { (task) -> Any? in
guard task.error == nil else {
if let urlError = task.error as NSError?, urlError.domain == NSURLErrorDomain {
self.fetchSignedInSessionWithOfflineError(completionHandler)

} else if let awsMobileClientError = task.error as? AWSMobileClientError {
if case .unableToSignIn = awsMobileClientError {
self.fetchSignedInSessionWithSessionExpiredError(completionHandler)
}
}
let authError = AuthErrorHelper.toAuthError(task.error!)
if let urlError = task.error as NSError?, urlError.domain == NSURLErrorDomain {
self.fetchSignedInSessionWithOfflineError(completionHandler)
return nil
}

if let awsMobileClientError = task.error as? AWSMobileClientError,
case .unableToSignIn = awsMobileClientError {
self.fetchSignedInSessionWithSessionExpiredError(completionHandler)
return nil
}

if let error = task.error {
let authError = AuthErrorHelper.toAuthError(error)
self.fetchSignedInSession(withError: authError, completionHandler)
return nil
}

guard let identityId = task.result as String? else {
let error = AuthError.unknown("""
Could not fetch Identity Id from Identity Pool, but there was no error reported back from
Expand Down